Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lotus-shed: initial export cmd for markets related metadata #6840

Merged
merged 4 commits into from
Jul 27, 2021
Merged

lotus-shed: initial export cmd for markets related metadata #6840

merged 4 commits into from
Jul 27, 2021

Conversation

nonsense
Copy link
Member

@nonsense nonsense commented Jul 22, 2021 •
edited
Loading

This PR is adding commands to lotus-shed so that miners can rollback from a multi-process architecture - one where part of the repo metadata datastore is located on the markets node, and part of it on the sealing/proving node.

During rollback, we need to copy back all the relevant metadata keys/values back to the monolith repo metadata datastore.

TODO:

@nonsense nonsense requested a review from dirkmc July 22, 2021 16:48
@jennijuju jennijuju added the P2 P2: Should be resolved label Jul 23, 2021
@jennijuju jennijuju added this to the 1.11.1 milestone Jul 23, 2021
@jacobheun jacobheun added epic/MRA team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs labels Jul 23, 2021
@nonsense nonsense marked this pull request as ready for review July 26, 2021 10:37
@nonsense nonsense requested a review from a team as a code owner July 26, 2021 10:37
arajasek
arajasek approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only suggestion would be to perhaps add a verbose flag to the export -- I'm not sure if it's currently very noisy.

cmd/lotus-shed/market.go Outdated Show resolved Hide resolved
@nonsense @arajasek
Update cmd/lotus-shed/market.go
9d61f91 
Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com>
@raulk raulk merged commit 35c9034 into master Jul 27, 2021
@raulk raulk deleted the nonsense/lotus-shed-support-rollback-for-mra branch July 27, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulk raulk raulk approved these changes

@arajasek arajasek arajasek approved these changes

@dirkmc dirkmc Awaiting requested review from dirkmc

Assignees
No one assigned
Labels
P2 P2: Should be resolved team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs
Projects
None yet
Milestone
1.11.1
Development

Successfully merging this pull request may close these issues.
6 participants
@nonsense @raulk @arajasek @jacobheun @jennijuju @dirkmc